Re: [PATCH 18/25] [PATCH] turn priviled operations into macros in entry.S

--
On Wed, 8 Aug 2007, Andi Kleen wrote:

Steven Rostedt [off-list ref] writes:

quoted

On Wed, 8 Aug 2007, Andi Kleen wrote:

quoted

quoted

Probably not, but this part of the code I don't fully understand.

I would suggest to defer all this until at least one example to test it
(except vsmp which is too simple) is around.

Who uses that code? NMIs and debug regs?  Lguest only has the host handle
the NMIs (doesn't pass to guest). And we haven't gotten to debug regs. Who
else uses that part of the code?

I'm not sure I understand your question. You're asking who uses entry.S?
Answer would be everybody. If you asked something else please reformulate.

When I said "this part of the code I don't fully understand" I was not
talking about entry.S.  I understand entry.S very well, but the comment
was originally on the paranoid_restore code. Which I thought had to deal
with NMIs and such that I didn't worry about that I simply did the
default.

quoted

 paranoid_restore\trace:
      RESTORE_ALL 8
-     iretq
+     INTERRUPT_RETURN

I suspect Xen will need much more changes anyways because of its
ring 3 guest. Are these changes sufficient for lguest?

The above was what I was replying to.

-- Steve