Re: [PATCH] I386: Deactivate the test for the dead CONFIG_DEBUG_PAGE_TYPE variable.
flat view
From: Stefan Richter <stefanr@s5r6.in-berlin.de>
Date: 2007-07-06 18:25:57
Also in:
lkml
Robert P. J. Day wrote:
quoted hunk
Signed-off-by: Robert P. J. Day <redacted> ---diff --git a/arch/i386/kernel/vmi.c b/arch/i386/kernel/vmi.c
Maintainers are apparently those under "PARAVIRT_OPS INTERFACE". CCs added.
quoted hunk
index c12720d..e3ce5c8 100644--- a/arch/i386/kernel/vmi.c +++ b/arch/i386/kernel/vmi.c@@ -235,7 +235,7 @@ static void vmi_nop(void) { } -#ifdef CONFIG_DEBUG_PAGE_TYPE +#if 0 /* debug page type */ #ifdef CONFIG_X86_PAE #define MAX_BOOT_PTS (2048+4+1)@@ -336,7 +336,7 @@ static void vmi_check_page_type(u32 pfn, int type) #else #define vmi_set_page_type(p,t) do { } while (0) #define vmi_check_page_type(p,t) do { } while (0) -#endif +#endif /* debug page type */ #ifdef CONFIG_HIGHPTE static void *vmi_kmap_atomic_pte(struct page *page, enum km_type type)
This misnamed CONFIG_DEBUG_PAGE_TYPE (it's not a Kconfig variable) has about 120 lines debug code dangling on it. So, replacing it by #if 0 will hopefully motivate a kind janitor to send a removal patch for that debug code eventually. I don't do so just now because that code went in between 2.6.20 and 2.6.21-rc1, i.e. not so long ago. -- Stefan Richter -=====-=-=== -=== --==- http://arcgraph.de/sr/