On Wed, 2007-07-11 at 12:28 +0200, Christian Borntraeger wrote:

Am Mittwoch, 4. Juli 2007 schrieb Rusty Russell:

quoted

+static void try_fill_recv(struct virtnet_info *vi)

Hmm, so it allocates skbs until oom or until add_buf fails, right?

Yep.

Do you expect the add_buf call to fail if we have enough buffers? Who defines 
the amount of buffers we can add via add_buf?

There will be some internal limit on how many buffers the virtio
implementation supports, but depends on that implementation.  It could
be a number of buffers or a total number of descriptors.

Cheers,
Rusty.