Re: [PATCH 5/5] KVM: paravirt time source

Jeremy Fitzhardinge wrote:

quoted

+	.read			= read_hyper,
+	.mask			= CLOCKSOURCE_MASK(64),
+	.mult			= 1,
+	.shift			= 0,
  
    

It would be better to use a scale and shift here, so that adjtime has
something to work with when warping time.
  

I've updated this patch and switched to using a scale/shift like Xen is 
doing, but I must admit, I don't understand how it helps adjtime.  I 
poked around a bit and it wasn't obvious.

Why is having {mult=1<<22, shift=22} better for adjtime than {mult=1, 
shift=0}?

Regards,

ANthony Liguori

    J

  

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/