Re: [patch 8/9] lguest: the block driver
From: Jens Axboe <hidden>
Date: 2007-05-09 10:32:39
Also in:
lkml
From: Jens Axboe <hidden>
Date: 2007-05-09 10:32:39
Also in:
lkml
On Wed, May 09 2007, Pekka Enberg wrote:
On 5/9/07, akpm@linux-foundation.org [off-list ref] wrote:quoted
+/* Jens gave me this nice helper to end all chunks of a request. */ +static void end_entire_request(struct request *req, int uptodate) +{ + if (end_that_request_first(req, uptodate, req->hard_nr_sectors)) + BUG(); + add_disk_randomness(req->rq_disk); + blkdev_dequeue_request(req); + end_that_request_last(req, uptodate); +}Again, I would prefer this went straight into block/ll_rw_blk.c. Rene and I am using something similar in the new Mitsumi driver although one of us has a bug already, we're using req->nr_sectors for this...
Lets do it after it is merged, as not to create a hold-up point for lguest. Once it's in, I'll fix it up. -- Jens Axboe