On Mon, 2007-05-07 at 23:30 -0700, Jeremy Fitzhardinge wrote:

Rusty Russell wrote:

quoted

Looks good, you can slightly improve it to be the model use of new
module_param types by calling your functions param_set_rx_mode and
param_get_rx_mode, then simply using "module_param(rx_mode, rx_mode,
0400)"
  

Cute.  I tried it out, but it doesn't yield an obvious improvement:

Of course not, but it's the Right Way!

Thanks,
Rusty.