RE: [Xen-devel] Re: [patch 21/26] Xen-paravirt_ops: Use the hvc console infrastructure for Xen console

But it is shorter than from JFK or Newark. 

-----Original Message-----
From: xen-devel-bounces@lists.xensource.com
[mailto:xen-devel-bounces@lists.xensource.com] On Behalf Of Keir Fraser
Sent: Friday, March 16, 2007 6:58 AM
To: Andrew Morton; Keir Fraser
Cc: xen-devel@lists.xensource.com; Andi Kleen;
linux-kernel@vger.kernel.org; Keir Fraser; Wright;
virtualization@lists.osdl.org; Ingo Molnar; Chris@smtp.osdl.org
Subject: Re: [Xen-devel] Re: [patch 21/26] Xen-paravirt_ops: Use the hvc
console infrastructure for Xen console

On 16/3/07 11:41, "Andrew Morton" [off-list ref] wrote:

quoted

It's needed for writing data /after/ reading the consumer index that

shows

quoted

you have space to write. Looking through xenbus_comms.c I think all

the

quoted

barriers are correct except there is a spurious extra mb() in

xb_read(),

quoted

where there is a later rmb() which is sufficient by itself. All the

others

quoted

have a purpose.

If Ingo couldn't work this out from reading the code then nobody else

can,

and we have a maintainability problem which can only be solved with
adequate commenting.

Agreed. I've fixed up the commenting, removed the spurious mb(), and I
just
need Jeremy to merge that change into the Xen pv_ops patchset. :-)

 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel