Thread (135 messages) 135 messages, 18 authors, 2007-03-20

Re: [patch 21/26] Xen-paravirt_ops: Use the hvc console infrastructure for Xen console

From: Jeremy Fitzhardinge <hidden>
Date: 2007-03-16 17:02:27
Also in: lkml, xen-devel

Ingo Molnar wrote:
quoted
+	prod = intf->in_prod;
+	mb();
+	BUG_ON((prod - cons) > sizeof(intf->in));
    
such mb()'s are typically a sign of "i have no clear idea what SMP 
serialization rules apply here, but something is needed because 
otherwise it breaks" ?
Hm, in this case its because it's sharing the memory with Xen, so
there's a particular ordering protocol.  It needs some comments.

    J
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help