Thread (45 messages) 45 messages, 10 authors, 2007-02-13

Re: [PATCH 1/10] lguest: Don't rely on last-linked fallthru when no paravirt handler

From: Rusty Russell <hidden>
Date: 2007-02-09 11:53:31
Also in: lkml

On Fri, 2007-02-09 at 10:31 +0100, Andi Kleen wrote:
On Friday 09 February 2007 10:14, Rusty Russell wrote:
quoted
+unhandled_paravirt:
+	/* Nothing wanted us: try to die with dignity (impossible trap). */ 
+	movl	$0x1F, %edx
+	pushl	$0
+	jmp	early_fault
Please print a real message with early_printk
If we make it thought early_fault, this will do just that.

Given this is a "never happens" situation, however... if you're actually
under Xen or lguest, you won't make it that far (lguest, at least, will
kill you on the cr2 load in early_fault, but it doesn't matter because
we won't get anywhere with early_printk anyway).

Actually, if we did BUG() here at least lguest would print something...
I wonder what Xen would do...

Rusty.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help