Re: [PATCH] Translate asm version of ELFNOTE macro into preprocessor macro
From: Ian Campbell <hidden>
Date: 2006-08-23 15:14:32
Also in:
lkml
From: Ian Campbell <hidden>
Date: 2006-08-23 15:14:32
Also in:
lkml
On Wed, 2006-08-23 at 07:49 -0700, Jeremy Fitzhardinge wrote:
Ian Campbell wrote:quoted
The first is that older gas does not support :varargs in .macro definitions (in my testing 2.17 does while 2.15 does not, I don't know when it became supported). The Changes file says binutils >= 2.12 so I think we need to avoid using it. There are no other uses in mainline or -mm. Old gas appears to just ignore it so you get "too many arguments" type errors.OK, seems reasonable. Eric Biederman solved this by having NOTE/ENDNOTE (or something like that) in his "bzImage with ELF header" patch, but I don't remember it being used in any way which is incompatible with using a CPP macro.
I can't find that patch, does NOTE/ENDNOTE just do the push/pop .note section? That would solve the problem with the first argument of the macro being a string but the final argument could still be for .asciz note contents. Ian.