Re: macb clock handling (Was: [PATCH v1 4/5] net: macb: Compatible as per device tree)
From: Heiko Stübner <heiko@sntech.de>
Date: 2021-11-25 19:33:01
Hi, Am Donnerstag, 11. November 2021, 10:41:46 CET schrieb Heiko Stübner:
not wanting to hijack this too much, but does the mac driver also need some sort of clock handling? Because on the Icicle I have here, I'm running into "TX timeout" errors: RISC-V # dhcp ethernet@20112000: PHY present at 9 ethernet@20112000: Starting autonegotiation... ethernet@20112000: Autonegotiation complete ethernet@20112000: link up, 1000Mbps full-duplex (lpa: 0x3800) BOOTP broadcast 1 ethernet@20112000: TX timeout BOOTP broadcast 2 ethernet@20112000: TX timeout BOOTP broadcast 3 ethernet@20112000: TX timeout BOOTP broadcast 4 ethernet@20112000: TX timeout The sifive variant of the macb distinguishes between speeds in its cllk_init callback, so I guess the Icicle might need that as well?
just for "the archive", i.e. when people read this in the future: I got this solved by updating the HSS to a recent release (2021.11 in this case). So now I do have working network in u-boot. Heiko
Am Freitag, 22. Oktober 2021, 10:56:47 CET schrieb Padmarao Begari:quoted
Update compatible as per Microchip PolarFire SoC ethernet device node. Signed-off-by: Padmarao Begari <redacted> --- drivers/net/macb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/net/macb.c b/drivers/net/macb.c index 8c6461e717..1b867bd5c2 100644 --- a/drivers/net/macb.c +++ b/drivers/net/macb.c@@ -1502,7 +1502,7 @@ static const struct udevice_id macb_eth_ids[] = { { .compatible = "cdns,zynq-gem" }, { .compatible = "sifive,fu540-c000-gem", .data = (ulong)&sifive_config }, - { .compatible = "microchip,mpfs-mss-gem", + { .compatible = "microchip,mpfs-gem", .data = (ulong)µchip_config }, { } };