Fix for build error /uboot/driver/video/simplefb.c

Started by ARJUN C R on Feb 2, 2020 · 4 messages from 2 authors · Last reply Mar 2, 2020

open the first message on its own page

ARJUN C R 

Hi,

diff:

--- u-boot-2020.04-rc1_new/drivers/video/simplefb.c 2020-02-02
16:31:57.416168719 +0530
+++ u-boot-2020.04-rc1/drivers/video/simplefb.c 2020-01-29
03:29:30.000000000 +0530
@@ -26,7 +26,7 @@ static int simple_video_probe(struct ude
  return -EINVAL;
  }

- debug("%s: base=%lx, size=%lu\n", __func__, base, size);
+ debug("%s: base=%llx, size=%llu\n", __func__, base, size);

  /*
  * TODO is there some way to reserve the framebuffer

variables base and size is unsinged long int, so the format specifier
should be %lx and %lu.

Regards
ARJUN C R

ARJUN C R replied to ARJUN C R 

Adding proper diff:

--- u-boot-2020.04-rc1/drivers/video/simplefb.c 2020-01-29
03:29:30.000000000 +0530
+++ u-boot-2020.04-rc1_new/drivers/video/simplefb.c 2020-02-02
16:31:57.416168719 +0530
@@ -26,7 +26,7 @@ static int simple_video_probe(struct ude
  return -EINVAL;
  }

- debug("%s: base=%llx, size=%llu\n", __func__, base, size);
+ debug("%s: base=%lx, size=%lu\n", __func__, base, size);

  /*
  * TODO is there some way to reserve the framebuffer

On Sun, Feb 2, 2020 at 4:35 PM ARJUN C R [off-list ref] wrote:
quoted hunk
Hi,

diff:

--- u-boot-2020.04-rc1_new/drivers/video/simplefb.c 2020-02-02
16:31:57.416168719 +0530
+++ u-boot-2020.04-rc1/drivers/video/simplefb.c 2020-01-29
03:29:30.000000000 +0530
@@ -26,7 +26,7 @@ static int simple_video_probe(struct ude
  return -EINVAL;
  }

- debug("%s: base=%lx, size=%lu\n", __func__, base, size);
+ debug("%s: base=%llx, size=%llu\n", __func__, base, size);

  /*
  * TODO is there some way to reserve the framebuffer

variables base and size is unsinged long int, so the format specifier
should be %lx and %lu.

Regards
ARJUN C R

ARJUN C R replied to ARJUN C R 

the fix still not added in git

On Sun, Feb 2, 2020, 4:35 PM ARJUN C R [off-list ref] wrote:
quoted hunk
Hi,

diff:

--- u-boot-2020.04-rc1_new/drivers/video/simplefb.c 2020-02-02
16:31:57.416168719 +0530
+++ u-boot-2020.04-rc1/drivers/video/simplefb.c 2020-01-29
03:29:30.000000000 +0530
@@ -26,7 +26,7 @@ static int simple_video_probe(struct ude
  return -EINVAL;
  }

- debug("%s: base=%lx, size=%lu\n", __func__, base, size);
+ debug("%s: base=%llx, size=%llu\n", __func__, base, size);

  /*
  * TODO is there some way to reserve the framebuffer

variables base and size is unsinged long int, so the format specifier
should be %lx and %lu.

Regards
ARJUN C R

Chris Packham replied to ARJUN C R 

On Mon, Mar 2, 2020 at 7:25 PM ARJUN C R [off-list ref] wrote:
the fix still not added in git
Most likely because it's not been submitted as a proper patch.

If you're keen to see it fixed have a look at
http://www.denx.de/wiki/U-Boot/Patches and submit a patch to address
the issue.

On Sun, Feb 2, 2020, 4:35 PM ARJUN C R [off-list ref] wrote:
quoted
Hi,

diff:

--- u-boot-2020.04-rc1_new/drivers/video/simplefb.c 2020-02-02
16:31:57.416168719 +0530
+++ u-boot-2020.04-rc1/drivers/video/simplefb.c 2020-01-29
03:29:30.000000000 +0530
@@ -26,7 +26,7 @@ static int simple_video_probe(struct ude
  return -EINVAL;
  }

- debug("%s: base=%lx, size=%lu\n", __func__, base, size);
+ debug("%s: base=%llx, size=%llu\n", __func__, base, size);

  /*
  * TODO is there some way to reserve the framebuffer

variables base and size is unsinged long int, so the format specifier
should be %lx and %lu.

Regards
ARJUN C R
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help