Thread (15 messages) 15 messages, 3 authors, 2018-07-19

[U-Boot] [RFC 1/2] env: Drop error messages when loading environment

flat view

From: Tom Rini <hidden>
Date: 2018-07-18 12:51:05

On Wed, Jul 18, 2018 at 08:19:50AM +0200, Wolfgang Denk wrote:
Dear Sam,

In message [ref] you wrote:
quoted
This is just a draft to discuss ideas related to "Make U-Boot log great
again" thread.

With this patch we will have something like this:

    Loading Environment from FAT... Failed (-5)
    Loading Environment from MMC... OK

instead of this:

    Loading Environment from FAT... MMC: no card present
    ** Bad device mmc 0 **
    Failed (-5)
    Loading Environment from MMC... OK
Why do you think an error message "Failed (-5)" looks great?

From a user's point of view, the "MMC: no card present"
is _much_ better (but of course it could still be improved).

Printing cryptic error codes has never been a good idea and is
definitly not a "great" idea.
Agreed, I don't think we want to go down the path of just suppressing
some of these error messages, that's not helpful.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180718/f87fd88e/attachment.sig>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help