common: env_sf: Add exclamation mark

Started by Peng Fan on Mar 28, 2016 · 3 messages from 2 authors · Last reply Apr 2, 2016

Subsystems (1)

Maintainers (1)

STALE3872d

open the first message on its own page

  1. [U-Boot] [PATCH] common: env_sf: Add exclamation mark
    Related patches
Message details and related content
Add exclamation mark to the errmsg, when error and set_default_env.

Signed-off-by: Peng Fan <redacted>
Cc: Mario Schuknecht <redacted>
Cc: Vignesh R <vigneshr@ti.com>
Cc: Jagan Teki <redacted>
Cc: Ravi Babu <redacted>
Cc: York Sun <redacted>
Cc: Tom Rini <redacted>
---
 common/env_sf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/env_sf.c b/common/env_sf.c
index 892e6cb..273098c 100644
--- a/common/env_sf.c
+++ b/common/env_sf.c
@@ -225,7 +225,7 @@ void env_relocate_spec(void)
 	ret = env_import((char *)ep, 0);
 	if (!ret) {
 		error("Cannot import environment: errno = %d\n", errno);
-		set_default_env("env_import failed");
+		set_default_env("!env_import failed");
 	}
 
 err_read:
-- 
2.6.2
Message details and related content
On Mon, Mar 28, 2016 at 05:26:27PM +0800, Peng Fan wrote:
Add exclamation mark to the errmsg, when error and set_default_env.
This is awkwardly worded.  We aren't adding a literal ! to the errmsg
itself, we're adding that as a flag.  I'll try and re-word this when
applying to be clearer.
Signed-off-by: Peng Fan <redacted>
Cc: Mario Schuknecht <redacted>
Cc: Vignesh R <vigneshr@ti.com>
Cc: Jagan Teki <redacted>
Cc: Ravi Babu <redacted>
Cc: York Sun <redacted>
Cc: Tom Rini <redacted>
Reviewed-by: Tom Rini <redacted>

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160328/f12c0349/attachment.sig>

[U-Boot] common: env_sf: Add exclamation mark

Message details and related content
On Mon, Mar 28, 2016 at 05:26:27PM +0800, Peng Fan wrote:
Add exclamation mark to the errmsg, when error and set_default_env.

Signed-off-by: Peng Fan <redacted>
Cc: Mario Schuknecht <redacted>
Cc: Vignesh R <vigneshr@ti.com>
Cc: Jagan Teki <redacted>
Cc: Ravi Babu <redacted>
Cc: York Sun <redacted>
Cc: Tom Rini <redacted>
Reviewed-by: Tom Rini <redacted>
Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160401/b76d39c6/attachment.sig>
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help