6.1-stable review patch. If anyone has any objections, please let me know.
------------------
From: Dan Carpenter <redacted>
[ Upstream commit 89e756e3cc8d9c1ebc0f2b2f6912227073d93118 ]
The hid_check_device_match() returns true if we find a match and false
if we don't. But here it returns -ENODEV which becomes true instead
of false.
Fixes: 207733f92661 ("HID: split apart hid_device_probe to make logic more apparent")
Signed-off-by: Dan Carpenter <redacted>
Reviewed-by: Benjamin Tissoires <redacted>
Reviewed-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: Jiri Kosina <redacted>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
drivers/hid/hid-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
index d02a9b1b1467a..61dde8e3fbb25 100644
--- a/drivers/hid/hid-core.c
+++ b/drivers/hid/hid-core.c
@@ -2645,7 +2645,7 @@ static bool hid_check_device_match(struct hid_device *hdev,
{
*id = hid_match_device(hdev, hdrv);
if (!*id)
- return -ENODEV;
+ return false;
if (hdrv->match)
return hdrv->match(hdev, hid_ignore_special_drivers);--
2.53.0