[PATCH 5.10.y 1/2] irqchip/stm32-exti: Split MCU and MPU code
From: Sasha Levin <sashal@kernel.org>
Date: 2026-09-10 15:44:47
Subsystem:
irqchip drivers, the rest · Maintainers:
Thomas Gleixner, Linus Torvalds
From: Antonio Borneo <antonio.borneo@foss.st.com> [ Upstream commit 350755e2e548ccbe941d045900b57233efa906cb ] Keep only the code for ARMv7m STM32 MCUs in in stm32-exti.c and split out the code for ARMv7a & ARMv8a STM32MPxxx MPUs into stm32mp-exti.c Signed-off-by: Antonio Borneo <antonio.borneo@foss.st.com> Signed-off-by: Thomas Gleixner <redacted> Link: https://lore.kernel.org/r/20240620083115.204362-5-antonio.borneo@foss.st.com (local) Backport dependency adaptation for Linux 6.1: The stable driver predates STM32MP_EXTI selection, standard device PM, interrupts-extended mappings, and secure/RIF event handling. Importing the upstream split would pull in those unrelated changes and new functions. Limit this dependency to relocating the existing combined MCU/MPU driver to irq-stm32mp-exti.c and updating its existing STM32_EXTI Makefile entry. Keep Kconfig, syscore PM, interrupt mappings, and all existing functions. Retain the upstream removal of unused hwspinlock handling from the MCU set-type callback: MCU host initialization never assigns a hwspinlock. This leaves the MPU callback as the only timeout user, so the target's macro rename fixes all remaining users without leaving an undefined name. Match the upstream timeout-definition context, including its two register macros, so d31fbbade43f880b7e59e2b3a72722fe2725d93f applies unchanged. The register macros remain unused; no secure/RIF behavior is introduced. [ sashal: Reduced backport -- upstream 350755e2e548c touches 4 file(s), this backport carries 2. Not backported here: drivers/irqchip/irq-stm32-exti.c drivers/irqchip/Kconfig This note is generated from the file lists only; see the resolution record for the reasoning. ] Stable-dep-of: d31fbbade43f ("irqchip/stm32mp-exti: Fix the unit of the hwspinlock timeout") Signed-off-by: Sasha Levin <sashal@kernel.org> --- drivers/irqchip/Makefile | 2 +- .../{irq-stm32-exti.c => irq-stm32mp-exti.c} | 21 ++++++------------- 2 files changed, 7 insertions(+), 16 deletions(-) rename drivers/irqchip/{irq-stm32-exti.c => irq-stm32mp-exti.c} (98%)
diff --git a/drivers/irqchip/Makefile b/drivers/irqchip/Makefile
index 94c2885882ee1..f659fe07928db 100644
--- a/drivers/irqchip/Makefile
+++ b/drivers/irqchip/Makefile@@ -88,7 +88,7 @@ obj-$(CONFIG_LS_EXTIRQ) += irq-ls-extirq.o obj-$(CONFIG_LS_SCFG_MSI) += irq-ls-scfg-msi.o obj-$(CONFIG_EZNPS_GIC) += irq-eznps.o obj-$(CONFIG_ARCH_ASPEED) += irq-aspeed-vic.o irq-aspeed-i2c-ic.o irq-aspeed-scu-ic.o -obj-$(CONFIG_STM32_EXTI) += irq-stm32-exti.o +obj-$(CONFIG_STM32_EXTI) += irq-stm32mp-exti.o obj-$(CONFIG_QCOM_IRQ_COMBINER) += qcom-irq-combiner.o obj-$(CONFIG_IRQ_UNIPHIER_AIDET) += irq-uniphier-aidet.o obj-$(CONFIG_ARCH_SYNQUACER) += irq-sni-exiu.o
diff --git a/drivers/irqchip/irq-stm32-exti.c b/drivers/irqchip/irq-stm32mp-exti.c
similarity index 98%
rename from drivers/irqchip/irq-stm32-exti.c
rename to drivers/irqchip/irq-stm32mp-exti.c
index cec9080cccad0..ed43ced2d6ed1 100644
--- a/drivers/irqchip/irq-stm32-exti.c
+++ b/drivers/irqchip/irq-stm32mp-exti.c@@ -22,9 +22,12 @@ #include <dt-bindings/interrupt-controller/arm-gic.h> -#define IRQS_PER_BANK 32 +#define IRQS_PER_BANK 32 -#define HWSPNLCK_TIMEOUT 1000 /* usec */ +#define HWSPNLCK_TIMEOUT 1000 /* usec */ + +#define EXTI_EnCIDCFGR(n) (0x180 + (n) * 4) +#define EXTI_HWCFGR1 0x3f0 struct stm32_exti_bank { u32 imr_ofst;
@@ -301,33 +304,21 @@ static int stm32_irq_set_type(struct irq_data *d, unsigned int type) struct irq_chip_generic *gc = irq_data_get_irq_chip_data(d); struct stm32_exti_chip_data *chip_data = gc->private; const struct stm32_exti_bank *stm32_bank = chip_data->reg_bank; - struct hwspinlock *hwlock = chip_data->host_data->hwlock; u32 rtsr, ftsr; int err; irq_gc_lock(gc); - if (hwlock) { - err = hwspin_lock_timeout_in_atomic(hwlock, HWSPNLCK_TIMEOUT); - if (err) { - pr_err("%s can't get hwspinlock (%d)\n", __func__, err); - goto unlock; - } - } - rtsr = irq_reg_readl(gc, stm32_bank->rtsr_ofst); ftsr = irq_reg_readl(gc, stm32_bank->ftsr_ofst); err = stm32_exti_set_type(d, type, &rtsr, &ftsr); if (err) - goto unspinlock; + goto unlock; irq_reg_writel(gc, rtsr, stm32_bank->rtsr_ofst); irq_reg_writel(gc, ftsr, stm32_bank->ftsr_ofst); -unspinlock: - if (hwlock) - hwspin_unlock_in_atomic(hwlock); unlock: irq_gc_unlock(gc);
--
2.53.0