Thread (2 messages) 2 messages, 2 authors, 2026-01-23

[5.10] net/sched: act_ife: convert comma to semicolon

From: Ben Hutchings <hidden>
Date: 2026-01-21 14:39:57
Also in: linux-rt-devel

Hello stable maintainers,

There has been a build regression for the 5.10 stable branch when both
CONFIG_NET_ACT_IFE and CONFIG_PREEMPT_RT are enabled.  This was
introduced by the backport of commit ce50039be49e ("net: sched: act_ife:
initialize struct tc_ife to fix KMSAN kernel-infoleak") in 5.10.247.

After that change, tcf_ife_dump() includes the single statement:

        opt.index = ife->tcf_index,
        opt.refcnt = refcount_read(&ife->tcf_refcnt) - ref,
        opt.bindcnt = atomic_read(&ife->tcf_bindcnt) - bind,
 
        spin_lock_bh(&ife->tcf_lock);

But with CONFIG_PREEMPT_RT enabled, spin_lock_bh() is a macro whose
expansion starts with "do", so this is a syntax error.

For 5.15-rt and newer, spin_lock_bh() is a function, and 5.4 is EOL, so
only 5.10 is affected.

Please cherry-pick commit 205305c028ad ("net/sched: act_ife: convert
comma to semicolon") to fix this for 5.10.  It should be harmless to
apply to later branches as well, of course.

Ben.

-- 
Ben Hutchings
I'm always amazed by the number of people who take up solipsism because
they heard someone else explain it. - E*Borg on alt.fan.pratchett

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help