Re: [PATCH 5.10 003/300] btrfs: always drop log root tree reference in btrfs_replay_log()

On Wed, 2025-12-03 at 16:23 +0100, Greg Kroah-Hartman wrote:

5.10-stable review patch.  If anyone has any objections, please let me know.

------------------

From: Filipe Manana <redacted>

[ Upstream commit 2f5b8095ea47b142c56c09755a8b1e14145a2d30 ]

Currently we have this odd behaviour:

1) At btrfs_replay_log() we drop the reference of the log root tree if
   the call to btrfs_recover_log_trees() failed;

2) But if the call to btrfs_recover_log_trees() did not fail, we don't
   drop the reference in btrfs_replay_log() - we expect that
   btrfs_recover_log_trees() does it in case it returns success.

Let's simplify this and make btrfs_replay_log() always drop the reference
on the log root tree, not only this simplifies code as it's what makes
sense since it's btrfs_replay_log() who grabbed the reference in the first
place.

[...]

This looks like cleanup rather than a bug fix, and I don't see any other
patches in the series that depend on it.

Ben.

-- 
Ben Hutchings
It is easier to change the specification to fit the program
than vice versa.