Re: [PATCH] gpio: Revert regression in sysfs-gpio (gpiolib.c)
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2021-12-20 15:16:29
Also in:
linux-gpio, regressions
On Mon, Dec 20, 2021 at 3:57 PM Bartosz Golaszewski [off-list ref] wrote:
On Sat, Dec 18, 2021 at 7:28 AM Thorsten Leemhuis [off-list ref] wrote:quoted
[TLDR: I'm adding this regression to regzbot, the Linux kernel regression tracking bot; most text you find below is compiled from a few templates paragraphs some of you might have seen already.] On 17.12.21 16:35, Marcelo Roberto Jimenez wrote:quoted
Some GPIO lines have stopped working after the patch commit 2ab73c6d8323f ("gpio: Support GPIO controllers without pin-ranges") And this has supposedly been fixed in the following patches commit 89ad556b7f96a ("gpio: Avoid using pin ranges with !PINCTRL") commit 6dbbf84603961 ("gpiolib: Don't free if pin ranges are not defined")There seems to be a backstory here. Are there any entries and bug trackers or earlier discussions everyone that looks into this should be aware of?Agreed with Thorsten. I'd like to first try to determine what's wrong before reverting those, as they are correct in theory but maybe the implementation missed something. Have you tried tracing the execution on your platform in order to see what the driver is doing?
Looking at commits that have related Fixes tags: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=bf781869e5cf3e4ec1a47dad69b6f0df97629cbd https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git/commit/?id=e8f24c58d1b69ecf410a673c22f546dc732bb879 Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds