Re: [PATCH 1/2] io_uring: check tctx->in_idle when decrementing inflight_tracked

On 12/10/21 12:21 AM, Hao Xu wrote:

在 2021/12/9 下午11:59, Jens Axboe 写道:

quoted

If we have someone potentially waiting for tracked requests to finish,
ensure that we check in_idle and wake them up appropriately.

Cc: stable@vger.kernel.org
Signed-off-by: Jens Axboe <axboe@kernel.dk>
---

Hi Jens,

I saw every/several( in batching cases)  io_clean_op() followed by an 
io_put_task() which does the same thing

as this patch, so it seems this one is not neccessary? Correct me if I'm 
wrong since I haven't touch this code for

Hard to deduce as it also depends on whether it's the task itself or not.
Making it explicit is better imho.

-- 
Jens Axboe