Thread (15 messages) 15 messages, 4 authors, 2022-01-05

Re: [PATCH v3 0/5] aio: fix use-after-free and missing wakeups

From: Eric Biggers <ebiggers@kernel.org>
Date: 2021-12-09 18:37:33
Also in: linux-fsdevel, lkml

On Thu, Dec 09, 2021 at 10:00:50AM -0800, Linus Torvalds wrote:
On Wed, Dec 8, 2021 at 5:06 PM Eric Biggers [off-list ref] wrote:
quoted
Careful review is appreciated; the aio poll code is very hard to work
with, and it doesn't appear to have many tests.  I've verified that it
passes the libaio test suite, which provides some coverage of poll.

Note, it looks like io_uring has the same bugs as aio poll.  I haven't
tried to fix io_uring.
I'm hoping Jens is looking at the io_ring case, but I'm also assuming
that I'll just get a pull request for this at some point.

It looks sane to me - my only internal cursing has been about epoll
and aio in general, not about these patches in particular.
I was hoping that Al would review and apply these, given that he's listed as the
maintainer for this file, and he's worked on this code before.  I was also
hoping for review from Christoph, since he added IOCB_CMD_POLL originally.  But
yes, if I don't hear anything I'll just send you a pull request.  I might
include https://lore.kernel.org/r/20210913111928.98-1-xieyongji@bytedance.com (local)
too, since it's an obviously correct aio fix which has been ignored for months.

- Eric
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help