Thread (96 messages) 96 messages, 8 authors, 2021-12-15

Lifecycle

  1. Posted Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  2. Reviewed-by Eugen Hristev

[PATCH 5.4 79/88] iio: at91-sama5d2: Fix incorrect sign extension

From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date: 2021-12-13 10:01:31
Also in: lkml

From: Gwendal Grignou <redacted>

commit 652e7df485c6884d552085ae2c73efa6cfea3547 upstream.

Use scan_type when processing raw data which also fixes that the sign
extension was from the wrong bit.

Use channel definition as root of trust and replace constant
when reading elements directly using the raw sysfs attributes.

Fixes: 6794e23fa3fe ("iio: adc: at91-sama5d2_adc: add support for oversampling resolution")
Signed-off-by: Gwendal Grignou <redacted>
Reviewed-by: Eugen Hristev <redacted>
Cc: <redacted>
Link: https://lore.kernel.org/r/20211104082413.3681212-9-gwendal@chromium.org (local)
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
 drivers/iio/adc/at91-sama5d2_adc.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
--- a/drivers/iio/adc/at91-sama5d2_adc.c
+++ b/drivers/iio/adc/at91-sama5d2_adc.c
@@ -1369,7 +1369,8 @@ static int at91_adc_read_info_raw(struct
 		*val = st->conversion_value;
 		ret = at91_adc_adjust_val_osr(st, val);
 		if (chan->scan_type.sign == 's')
-			*val = sign_extend32(*val, 11);
+			*val = sign_extend32(*val,
+					     chan->scan_type.realbits - 1);
 		st->conversion_done = false;
 	}
 

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help