Re: [PATCH v2] mhi: pci_generic: Graceful shutdown on freeze
From: Manivannan Sadhasivam <mani@kernel.org>
Date: 2021-11-18 06:17:25
Also in:
linux-arm-msm
On Tue, Oct 26, 2021 at 07:09:40PM +0200, Loic Poulain wrote:
There is no reason for shutting down MHI ungracefully on freeze,
this causes the MHI host stack & device stack to not be aligned
anymore since the proper MHI reset sequence is not performed for
ungraceful shutdown.
Cc: stable@vger.kernel.org
Fixes: 5f0c2ee1fe8d ("bus: mhi: pci-generic: Fix hibernation")
Suggested-by: Bhaumik Bhatt <redacted>
Signed-off-by: Loic Poulain <redacted>
Reviewed-by: Bhaumik Bhatt <redacted>
Reviewed-by: Hemant Kumar <redacted>Applied to mhi-next! Thanks, Mani
quoted hunk ↗ jump to hunk
--- v2: Forgot to mention this change comes from a Bhaumik suggestion drivers/bus/mhi/pci_generic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/bus/mhi/pci_generic.c b/drivers/bus/mhi/pci_generic.c index 6a42425..d4a3ce2 100644 --- a/drivers/bus/mhi/pci_generic.c +++ b/drivers/bus/mhi/pci_generic.c@@ -1018,7 +1018,7 @@ static int __maybe_unused mhi_pci_freeze(struct device *dev) * context. */ if (test_and_clear_bit(MHI_PCI_DEV_STARTED, &mhi_pdev->status)) { - mhi_power_down(mhi_cntrl, false); + mhi_power_down(mhi_cntrl, true); mhi_unprepare_after_power_down(mhi_cntrl); }-- 2.7.4