Thread (10 messages) 10 messages, 2 authors, 2021-11-19

Re: [PATCH v2 2/5] mtd: rawnand/davinci: Avoid duplicated page read

flat view

From: Miquel Raynal <miquel.raynal@bootlin.com>
Date: 2021-11-19 18:44:09
Also in: linux-mips, lkml

On Sat, 2021-10-16 at 13:22:25 UTC, Paul Cercueil wrote:
The function nand_davinci_read_page_hwecc_oob_first() first reads the
OOB data, extracts the ECC information, programs the ECC hardware before
reading the actual data in a loop.

Right after the OOB data was read, it called nand_read_page_op() to
reset the read cursor to the beginning of the page. This caused the
first page to be read twice: in that call, and later in the loop.

Address that issue by changing the call to nand_read_page_op() to
nand_change_read_column_op(), which will only reset the read cursor.

Cc: <redacted> # v5.2
Fixes: a0ac778eb82c ("mtd: rawnand: ingenic: Add support for the JZ4740")
Signed-off-by: Paul Cercueil <paul@crapouillou.net>
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.

Miquel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help