Re: [PATCH net] net: dsa: mt7530: correct ds->num_ports

On Mon, Oct 18, 2021 at 09:22:49AM -0700, Florian Fainelli wrote:

On 10/18/21 1:42 AM, DENG Qingfang wrote:

quoted

On Sat, Oct 16, 2021 at 07:36:14PM -0700, Florian Fainelli wrote:

quoted

On 10/15/2021 11:24 PM, DENG Qingfang wrote:

quoted

Setting ds->num_ports to DSA_MAX_PORTS made DSA core allocate unnecessary
dsa_port's and call mt7530_port_disable for non-existent ports.

Set it to MT7530_NUM_PORTS to fix that, and dsa_is_user_port check in
port_enable/disable is no longer required.

Cc: stable@vger.kernel.org
Signed-off-by: DENG Qingfang <dqfext@gmail.com>

Do you really want to target the net tree for this change?

Yes because I consider this a bug fix.

OK, why not provide a Fixes tag to help with targeting the back port
then? This has been applied anyway, so hopefully the auto selection will
do its job and tell you where it stops applying cleanly.

Without a "Fixes:" tag, I just backport things as far are they are easy
to go and then stop without an email saying anything fails on older
kernels.

thanks,

greg k-h