Thread (100 messages) 100 messages, 6 authors, 2021-10-05

[PATCH 5.10 70/93] debugfs: debugfs_create_file_size(): use IS_ERR to check for error

flat view
STALE1847d REVIEWED: 1 (1M)

From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date: 2021-10-04 13:24:55
Also in: lkml

1 review trailer.

From: Nirmoy Das <redacted>

commit af505cad9567f7a500d34bf183696d570d7f6810 upstream.

debugfs_create_file() returns encoded error so use IS_ERR for checking
return value.

Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Nirmoy Das <redacted>
Fixes: ff9fb72bc077 ("debugfs: return error values, not NULL")
Cc: stable <redacted>
Link: https://lore.kernel.org/r/20210902102917.2233-1-nirmoy.das@amd.com (local)
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
 fs/debugfs/inode.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
--- a/fs/debugfs/inode.c
+++ b/fs/debugfs/inode.c
@@ -524,7 +524,7 @@ void debugfs_create_file_size(const char
 {
 	struct dentry *de = debugfs_create_file(name, mode, parent, data, fops);
 
-	if (de)
+	if (!IS_ERR(de))
 		d_inode(de)->i_size = file_size;
 }
 EXPORT_SYMBOL_GPL(debugfs_create_file_size);

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help