Thread (5 messages) 5 messages, 2 authors, 2021-09-24
STALE1732d
Revisions (2)
  1. v1 current
  2. v2 [diff vs current]

[PATCH 2/3] leaking_addresses: Always print a trailing newline

From: Kees Cook <hidden>
Date: 2021-09-24 06:23:57
Also in: linux-fsdevel, linux-hardening, lkml
Subsystem: leaking_addresses, the rest · Maintainers: Tycho Andersen, Linus Torvalds

For files that lack trailing newlines and match a leaking address (e.g.
wchan[1]), the leaking_addresses.pl report would run together with the
net line, making things look corrupted.

Unconditionally remove the newline on input, and write it back out on
output.

[1] https://lore.kernel.org/all/20210103142726.GC30643@xsang-OptiPlex-9020/ (local)

Cc: "Tobin C. Harding" <redacted>
Cc: Tycho Andersen <tycho@tycho.pizza>
Signed-off-by: Kees Cook <redacted>
---
 scripts/leaking_addresses.pl | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/scripts/leaking_addresses.pl b/scripts/leaking_addresses.pl
index b2d8b8aa2d99..8f636a23bc3f 100755
--- a/scripts/leaking_addresses.pl
+++ b/scripts/leaking_addresses.pl
@@ -455,8 +455,9 @@ sub parse_file
 
 	open my $fh, "<", $file or return;
 	while ( <$fh> ) {
+		chomp;
 		if (may_leak_address($_)) {
-			print $file . ': ' . $_;
+			printf("$file: $_\n");
 		}
 	}
 	close $fh;
-- 
2.30.2
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help