Re: [PATCH 5.10 048/103] s390/qeth: fix deadlock during failing recovery
From: Naresh Kamboju <hidden>
Date: 2021-09-27 18:25:18
Also in:
lkml
On Mon, 27 Sept 2021 at 23:15, Naresh Kamboju [off-list ref] wrote:
Following commit caused the build failures on s390,
Also noticed on stable-rc 5.10 and 5.14 branches.
quoted
diff --git a/drivers/s390/net/qeth_core_main.c b/drivers/s390/net/qeth_core_main.c index 7b0155b0e99e..15477bfb5bd8 100644 --- a/drivers/s390/net/qeth_core_main.c +++ b/drivers/s390/net/qeth_core_main.c@@ -5406,7 +5406,8 @@ static int qeth_do_reset(void *data) dev_info(&card->gdev->dev, "Device successfully recovered!\n"); } else { - ccwgroup_set_offline(card->gdev); + qeth_set_offline(card, disc, true); + ccwgroup_set_offline(card->gdev, false);drivers/s390/net/qeth_core_main.c: In function 'qeth_close_dev_handler': drivers/s390/net/qeth_core_main.c:83:9: error: too few arguments to function 'ccwgroup_set_offline' 83 | ccwgroup_set_offline(card->gdev); | ^~~~~~~~~~~~~~~~~~~~ In file included from drivers/s390/net/qeth_core.h:44, from drivers/s390/net/qeth_core_main.c:46: arch/s390/include/asm/ccwgroup.h:61:5: note: declared here 61 | int ccwgroup_set_offline(struct ccwgroup_device *gdev, bool call_gdrv); | ^~~~~~~~~~~~~~~~~~~~ make[3]: *** [scripts/Makefile.build:280: drivers/s390/net/qeth_core_main.o] Error 1 Reported-by: Linux Kernel Functional Testing <redacted> Build url: https://gitlab.com/Linaro/lkft/mirrors/stable/linux-stable-rc/-/jobs/1626658768#L73 -- Linaro LKFT https://lkft.linaro.org