Re: [PATCH 1/2] power: supply: max17042_battery: Clear status bits in interrupt handler
From: Krzysztof Kozlowski <hidden>
Date: 2021-09-13 13:05:09
Also in:
linux-pm, lkml
On 12/09/2021 22:54, Sebastian Krzyszkowiak wrote:
quoted hunk ↗ jump to hunk
The gauge requires us to clear the status bits manually for some alerts to be properly dismissed. Previously the IRQ was configured to react only on falling edge, which wasn't technically correct (the ALRT line is active low), but it had a happy side-effect of preventing interrupt storms on uncleared alerts from happening. Fixes: 7fbf6b731bca ("power: supply: max17042: Do not enforce (incorrect) interrupt trigger type") Cc: <redacted> Signed-off-by: Sebastian Krzyszkowiak <sebastian.krzyszkowiak@puri.sm> --- drivers/power/supply/max17042_battery.c | 3 +++ 1 file changed, 3 insertions(+)diff --git a/drivers/power/supply/max17042_battery.c b/drivers/power/supply/max17042_battery.c index 8dffae76b6a3..c53980c8432a 100644 --- a/drivers/power/supply/max17042_battery.c +++ b/drivers/power/supply/max17042_battery.c@@ -876,6 +876,9 @@ static irqreturn_t max17042_thread_handler(int id, void *dev) max17042_set_soc_threshold(chip, 1); } + regmap_clear_bits(chip->regmap, MAX17042_STATUS, + 0xFFFF & ~(STATUS_POR_BIT | STATUS_BST_BIT)); +
Are you sure that this was the reason of interrupt storm? Not incorrect SoC value (read from register for ModelGauge m3 while not configuring fuel gauge model). You should only clear bits which you are awaken for... Have in mind that in DT-configuration the fuel gauge is most likely broken by missing configuration. With alert enabled, several other config fields should be cleared. Best regards, Krzysztof