Thread (39 messages) 39 messages, 10 authors, 2021-09-08
STALE1755d REVIEWED: 2 (2M)

[PATCH 5.10 24/29] ALSA: pcm: fix divide error in snd_pcm_lib_ioctl

From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date: 2021-09-06 12:57:44
Also in: lkml

From: Zubin Mithra <redacted>

commit f3eef46f0518a2b32ca1244015820c35a22cfe4a upstream.

Syzkaller reported a divide error in snd_pcm_lib_ioctl. fifo_size
is of type snd_pcm_uframes_t(unsigned long). If frame_size
is 0x100000000, the error occurs.

Fixes: a9960e6a293e ("ALSA: pcm: fix fifo_size frame calculation")
Signed-off-by: Zubin Mithra <redacted>
Reviewed-by: Guenter Roeck <groeck@chromium.org>
Cc: <redacted>
Link: https://lore.kernel.org/r/20210827153735.789452-1-zsm@chromium.org (local)
Signed-off-by: Takashi Iwai <redacted>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
 sound/core/pcm_lib.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
--- a/sound/core/pcm_lib.c
+++ b/sound/core/pcm_lib.c
@@ -1746,7 +1746,7 @@ static int snd_pcm_lib_ioctl_fifo_size(s
 		channels = params_channels(params);
 		frame_size = snd_pcm_format_size(format, channels);
 		if (frame_size > 0)
-			params->fifo_size /= (unsigned)frame_size;
+			params->fifo_size /= frame_size;
 	}
 	return 0;
 }

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help