Thread (2 messages) flat view 2 messages, 2 authors, 2021-08-25

Re: [PATCH v5] usb: dwc3: gadget: Stop EP0 transfers during pullup disable

From: Felipe Balbi <balbi@kernel.org>
Date: 2021-08-25 05:51:44
Also in: linux-usb, lkml

Wesley Cheng [off-list ref] writes:
During a USB cable disconnect, or soft disconnect scenario, a pending
SETUP transaction may not be completed, leading to the following
error:

    dwc3 a600000.dwc3: timed out waiting for SETUP phase

If this occurs, then the entire pullup disable routine is skipped and
proper cleanup and halting of the controller does not complete.

Instead of returning an error (which is ignored from the UDC
perspective), allow the pullup disable routine to continue, which
will also handle disabling of EP0/1.  This will end any active
transfers as well.  Ensure to clear any delayed_status also, as the
timeout could happen within the STATUS stage.

Cc: <redacted>
Fixes: bb0147364850 ("usb: dwc3: gadget: don't clear RUN/STOP when it's invalid to do so")
Reviewed-by: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
Signed-off-by: Wesley Cheng <redacted>
Acked-by: Felipe Balbi <balbi@kernel.org>

-- 
balbi
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help