Thread (183 messages) flat view 183 messages, 7 authors, 2021-08-12
STALE1834d REVIEWED: 1 (0M)

1 review trailer.

[PATCH 5.13 116/175] staging: rtl8723bs: Fix a resource leak in sd_int_dpc

From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date: 2021-08-10 18:03:06
Also in: lkml

From: Xiangyang Zhang <redacted>

commit 990e4ad3ddcb72216caeddd6e62c5f45a21e8121 upstream.

The "c2h_evt" variable is not freed when function call
"c2h_evt_read_88xx" failed

Fixes: 554c0a3abf21 ("staging: Add rtl8723bs sdio wifi driver")
Reviewed-by: Hans de Goede <redacted>
Signed-off-by: Xiangyang Zhang <redacted>
Cc: stable <redacted>
Link: https://lore.kernel.org/r/20210628152239.5475-1-xyz.sun.ok@gmail.com (local)
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
 drivers/staging/rtl8723bs/hal/sdio_ops.c |    2 ++
 1 file changed, 2 insertions(+)
--- a/drivers/staging/rtl8723bs/hal/sdio_ops.c
+++ b/drivers/staging/rtl8723bs/hal/sdio_ops.c
@@ -921,6 +921,8 @@ void sd_int_dpc(struct adapter *adapter)
 				} else {
 					rtw_c2h_wk_cmd(adapter, (u8 *)c2h_evt);
 				}
+			} else {
+				kfree(c2h_evt);
 			}
 		} else {
 			/* Error handling for malloc fail */

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help