Re: [PATCH v4 2/2] blk-zoned: allow BLKREPORTZONE without CAP_SYS_ADMIN
flat view
From: Niklas Cassel <hidden>
Date: 2021-08-09 10:05:06
Also in:
linux-block, lkml
On Mon, Aug 09, 2021 at 09:58:17AM +0000, Johannes Thumshirn wrote:
On 09/08/2021 11:50, Niklas Cassel wrote:quoted
From: Niklas Cassel <redacted> A user space process should not need the CAP_SYS_ADMIN capability set in order to perform a BLKREPORTZONE ioctl. Getting the zone report is required in order to get the write pointer. Neither read() nor write() requires CAP_SYS_ADMIN, so it is reasonable that a user space process that can read/write from/to the device, also can get the write pointer. (Since e.g. writes have to be at the write pointer.) Fixes: 3ed05a987e0f ("blk-zoned: implement ioctls") Signed-off-by: Niklas Cassel <redacted> Reviewed-by: Damien Le Moal <redacted>Nit: Missing 'w'
Seems like Damien's email had a typo in his original reply: https://patchwork.kernel.org/project/linux-block/patch/20210614122303.154378-3-Niklas.Cassel@wdc.com/#24252237 Surprised that he doesn't have a shortcut to paste his Reviewed-by tag, considering the amount of patches that he reviews :)
quoted
Reviewed-by: Aravind Ramesh <redacted> Reviewed-by: Adam Manzanares <redacted> Reviewed-by: Himanshu Madhani <redacted> Cc: stable@vger.kernel.org # v4.10+ ---Looks good, Reviewed-by: Johannes Thumshirn <redacted>