Re: [PATCH 2/2] PCI: Add Max Payload Size quirk for ASMedia ASM1062 SATA controller
From: Bjorn Helgaas <helgaas@kernel.org>
Date: 2021-07-26 17:24:24
Also in:
linux-pci
On Thu, Jun 24, 2021 at 07:14:18PM +0200, Marek Behún wrote:
The ASMedia ASM1062 SATA controller advertises Max_Payload_Size_Supported of 512, but in fact it cannot handle TLPs with payload size of 512. We discovered this issue on PCIe controllers capable of MPS = 512 (Aardvark and DesignWare), where the issue presents itself as an External Abort. Bjorn Helgaas says: Probably ASM1062 reports a Malformed TLP error when it receives a data payload of 512 bytes, and Aardvark, DesignWare, etc convert this to an arm64 External Abort. Limiting Max Payload Size to 256 bytes solves this problem. Signed-off-by: Marek Behún <kabel@kernel.org> BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=212695 Reported-by: Rötti <redacted> Cc: Pali Rohár <pali@kernel.org> Cc: stable@vger.kernel.org
Applied both to pci/enumeration for v5.15, thanks! Were you able to confirm that a Malformed TLP error was logged? The lspci in the bugzilla is from a system with no AER support, so no information from that one. I don't know if any of the PCIe controllers you tested support both AER and MPS=512.
quoted hunk ↗ jump to hunk
--- drivers/pci/quirks.c | 1 + 1 file changed, 1 insertion(+)diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c index 4d9b9d8fbc43..a4ba3e3b3c5e 100644 --- a/drivers/pci/quirks.c +++ b/drivers/pci/quirks.c@@ -3239,6 +3239,7 @@ DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_SOLARFLARE, PCI_DEVICE_ID_SOLARFLARE_SFC4000A_1, fixup_mpss_256); DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_SOLARFLARE, PCI_DEVICE_ID_SOLARFLARE_SFC4000B, fixup_mpss_256); +DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_ASMEDIA, 0x0612, fixup_mpss_256); /* * Intel 5000 and 5100 Memory controllers have an erratum with read completion-- 2.31.1