[PATCH AUTOSEL 5.4 38/63] gpio: zynq: Check return value of pm_runtime_get_sync
From: Sasha Levin <sashal@kernel.org>
Date: 2021-07-10 02:34:03
Also in:
linux-arm-kernel, linux-gpio, lkml
Subsystem:
gpio subsystem, the rest, xilinx gpio driver · Maintainers:
Linus Walleij, Bartosz Golaszewski, Linus Torvalds, Shubhrajyoti Datta
From: Srinivas Neeli <redacted> [ Upstream commit a51b2fb94b04ab71e53a71b9fad03fa826941254 ] Return value of "pm_runtime_get_sync" API was neither captured nor checked. Fixed it by capturing the return value and then checking for any warning. Addresses-Coverity: "check_return" Signed-off-by: Srinivas Neeli <redacted> Signed-off-by: Bartosz Golaszewski <redacted> Signed-off-by: Sasha Levin <sashal@kernel.org> --- drivers/gpio/gpio-zynq.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/gpio/gpio-zynq.c b/drivers/gpio/gpio-zynq.c
index 88b04d8a7fa7..25a42605aa81 100644
--- a/drivers/gpio/gpio-zynq.c
+++ b/drivers/gpio/gpio-zynq.c@@ -938,8 +938,11 @@ static int zynq_gpio_probe(struct platform_device *pdev) static int zynq_gpio_remove(struct platform_device *pdev) { struct zynq_gpio *gpio = platform_get_drvdata(pdev); + int ret; - pm_runtime_get_sync(&pdev->dev); + ret = pm_runtime_get_sync(&pdev->dev); + if (ret < 0) + dev_warn(&pdev->dev, "pm_runtime_get_sync() Failed\n"); gpiochip_remove(&gpio->chip); clk_disable_unprepare(gpio->clk); device_set_wakeup_capable(&pdev->dev, 0);
--
2.30.2