[PATCH 5.12 029/110] dmaengine: idxd: Fix missing error code in idxd_cdev_open()
From: Sasha Levin <sashal@kernel.org>
Date: 2021-06-28 14:21:00
Also in:
lkml
Subsystem:
dma generic offload engine subsystem, intel idxd driver, the rest · Maintainers:
Vinod Koul, Vinicius Costa Gomes, Linus Torvalds
From: Jiapeng Chong <redacted> [ Upstream commit 99b18e88a1cf737ae924123d63b46d9a3d17b1af ] The error code is missing in this code scenario, add the error code '-EINVAL' to the return value 'rc'. Eliminate the follow smatch warning: drivers/dma/idxd/cdev.c:113 idxd_cdev_open() warn: missing error code 'rc'. Reported-by: Abaci Robot <redacted> Signed-off-by: Jiapeng Chong <redacted> Acked-by: Dave Jiang <dave.jiang@intel.com> Link: https://lore.kernel.org/r/1622628446-87909-1-git-send-email-jiapeng.chong@linux.alibaba.com (local) Signed-off-by: Vinod Koul <vkoul@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org> --- drivers/dma/idxd/cdev.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/dma/idxd/cdev.c b/drivers/dma/idxd/cdev.c
index 1d8a3876b745..5ba8e8bc609f 100644
--- a/drivers/dma/idxd/cdev.c
+++ b/drivers/dma/idxd/cdev.c@@ -110,6 +110,7 @@ static int idxd_cdev_open(struct inode *inode, struct file *filp) pasid = iommu_sva_get_pasid(sva); if (pasid == IOMMU_PASID_INVALID) { iommu_sva_unbind_device(sva); + rc = -EINVAL; goto failed; }
--
2.30.2