[PATCH 5.10 639/663] gfs2: Lock imbalance on error path in gfs2_recover_one
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date: 2021-03-02 04:09:06
Also in:
lkml
From: Andreas Gruenbacher <agruenba@redhat.com>
commit 834ec3e1ee65029029225a86c12337a6cd385af7 upstream.
In gfs2_recover_one, fix a sd_log_flush_lock imbalance when a recovery
pass fails.
Fixes: c9ebc4b73799 ("gfs2: allow journal replay to hold sd_log_flush_lock")
Cc: stable@vger.kernel.org # v5.7+
Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
fs/gfs2/recovery.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
--- a/fs/gfs2/recovery.c
+++ b/fs/gfs2/recovery.c@@ -514,8 +514,10 @@ void gfs2_recover_func(struct work_struc error = foreach_descriptor(jd, head.lh_tail, head.lh_blkno, pass); lops_after_scan(jd, error, pass); - if (error) + if (error) { + up_read(&sdp->sd_log_flush_lock); goto fail_gunlock_thaw; + } } recover_local_statfs(jd, &head);