Re: [PATCH] MIPS: Support binutils configured with --enable-mips-fix-loongson3-llsc=yes
From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Date: 2021-01-15 14:48:09
Also in:
linux-mips, lkml
From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Date: 2021-01-15 14:48:09
Also in:
linux-mips, lkml
On Sat, Jan 09, 2021 at 08:30:47PM +0100, Aurelien Jarno wrote:
quoted
From version 2.35, binutils can be configured with--enable-mips-fix-loongson3-llsc=yes, which means it defaults to -mfix-loongson3-llsc. This breaks labels which might then point at the wrong instruction. The workaround to explicitly pass -mno-fix-loongson3-llsc has been added in Linux version 5.1, but is only enabled when building a Loongson 64 kernel. As vendors might use a common toolchain for building Loongson and non-Loongson kernels, just move that workaround to arch/mips/Makefile. At the same time update the comments to reflect the current status. Cc: stable@vger.kernel.org # 5.1+ Cc: YunQiang Su <redacted> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net> --- arch/mips/Makefile | 19 +++++++++++++++++++ arch/mips/loongson64/Platform | 22 ---------------------- 2 files changed, 19 insertions(+), 22 deletions(-)
I've applied it to mips-next, but I consider such changes as rather rude. I would have expected, that the workaround is only enabled via command line option and not by default. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]