Thread (97 messages) flat view 97 messages, 5 authors, 2021-01-12
STALE2036d REVIEWED: 1 (0M)

1 review trailer.

[PATCH 5.4 69/92] usb: gadget: function: printer: Fix a memory leak for interface descriptor

From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date: 2021-01-11 13:38:32
Also in: lkml

From: Zqiang <redacted>

commit 2cc332e4ee4febcbb685e2962ad323fe4b3b750a upstream.

When printer driver is loaded, the printer_func_bind function is called, in
this function, the interface descriptor be allocated memory, if after that,
the error occurred, the interface descriptor memory need to be free.

Reviewed-by: Peter Chen <redacted>
Cc: <redacted>
Signed-off-by: Zqiang <redacted>
Link: https://lore.kernel.org/r/20201210020148.6691-1-qiang.zhang@windriver.com (local)
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

---
 drivers/usb/gadget/function/f_printer.c |    1 +
 1 file changed, 1 insertion(+)
--- a/drivers/usb/gadget/function/f_printer.c
+++ b/drivers/usb/gadget/function/f_printer.c
@@ -1126,6 +1126,7 @@ fail_tx_reqs:
 		printer_req_free(dev->in_ep, req);
 	}
 
+	usb_free_all_descriptors(f);
 	return ret;
 
 }

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help