Thread (15 messages) flat view 15 messages, 6 authors, 2021-01-09
STALE2041d

[PATCH 4.19 4/8] dmaengine: at_hdmac: add missing kfree() call in at_dma_xlate()

From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date: 2021-01-07 14:32:32
Also in: lkml

From: Yu Kuai <redacted>

commit e097eb7473d9e70da9e03276f61cd392ccb9d79f upstream.

If memory allocation for 'atslave' succeed, at_dma_xlate() doesn't have a
corresponding kfree() in exception handling. Thus add kfree() for this
function implementation.

Fixes: bbe89c8e3d59 ("at_hdmac: move to generic DMA binding")
Signed-off-by: Yu Kuai <redacted>
Link: https://lore.kernel.org/r/20200817115728.1706719-4-yukuai3@huawei.com (local)
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

---
 drivers/dma/at_hdmac.c |    1 +
 1 file changed, 1 insertion(+)
--- a/drivers/dma/at_hdmac.c
+++ b/drivers/dma/at_hdmac.c
@@ -1718,6 +1718,7 @@ static struct dma_chan *at_dma_xlate(str
 	chan = dma_request_channel(mask, at_dma_filter, atslave);
 	if (!chan) {
 		put_device(&dmac_pdev->dev);
+		kfree(atslave);
 		return NULL;
 	}
 

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help