Thread (399 messages) 399 messages, 6 authors, 2020-08-18

[PATCH 5.7 290/393] wl1251: fix always return 0 error

flat view
STALE2246d

From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date: 2020-08-17 18:46:33
Also in: lkml
Subsystem: the rest, ti wilink wireless drivers · Maintainer: Linus Torvalds

From: Wang Hai <redacted>

[ Upstream commit 20e6421344b5bc2f97b8e2db47b6994368417904 ]

wl1251_event_ps_report() should not always return 0 because
wl1251_ps_set_mode() may fail. Change it to return 'ret'.

Fixes: f7ad1eed4d4b ("wl1251: retry power save entry")
Reported-by: Hulk Robot <redacted>
Signed-off-by: Wang Hai <redacted>
Signed-off-by: Kalle Valo <redacted>
Link: https://lore.kernel.org/r/20200730073939.33704-1-wanghai38@huawei.com (local)
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
 drivers/net/wireless/ti/wl1251/event.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ti/wl1251/event.c b/drivers/net/wireless/ti/wl1251/event.c
index 850864dbafa11..e6d426edab56b 100644
--- a/drivers/net/wireless/ti/wl1251/event.c
+++ b/drivers/net/wireless/ti/wl1251/event.c
@@ -70,7 +70,7 @@ static int wl1251_event_ps_report(struct wl1251 *wl,
 		break;
 	}
 
-	return 0;
+	return ret;
 }
 
 static void wl1251_event_mbox_dump(struct event_mailbox *mbox)
-- 
2.25.1


Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help