[PATCH 5.5 024/150] USB: serial: ch341: fix receiver regression
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date: 2020-02-27 14:23:24
Also in:
lkml
From: Johan Hovold <johan@kernel.org>
commit 7c3d02285ad558691f27fde760bcd841baa27eab upstream.
While assumed not to make a difference, not using the factor-2 prescaler
makes the receiver more susceptible to errors.
Specifically, there have been reports of problems with devices that
cannot generate a 115200 rate with a smaller error than 2.1% (e.g.
117647 bps). But this can also be reproduced with a low-speed RS232
tranceiver at 115200 when the input rate matches the nominal rate.
So whenever possible, enable the factor-2 prescaler and halve the
divisor in order to use settings closer to that of the previous
algorithm.
Fixes: 35714565089e ("USB: serial: ch341: reimplement line-speed handling")
Cc: stable <redacted> # 5.5
Reported-by: Jakub Nantl <redacted>
Tested-by: Jakub Nantl <redacted>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
drivers/usb/serial/ch341.c | 10 ++++++++++
1 file changed, 10 insertions(+)
--- a/drivers/usb/serial/ch341.c
+++ b/drivers/usb/serial/ch341.c@@ -205,6 +205,16 @@ static int ch341_get_divisor(speed_t spe 16 * speed - 16 * CH341_CLKRATE / (clk_div * (div + 1))) div++; + /* + * Prefer lower base clock (fact = 0) if even divisor. + * + * Note that this makes the receiver more tolerant to errors. + */ + if (fact == 1 && div % 2 == 0) { + div /= 2; + fact = 0; + } + return (0x100 - div) << 8 | fact << 2 | ps; }