Re: [PATCH AUTOSEL 5.4 033/134] leds: an30259a: add a check for devm_regmap_init_i2c
From: Pavel Machek <hidden>
Date: 2019-12-14 08:43:01
Also in:
linux-leds, lkml
On Wed 2019-12-11 10:10:09, Sasha Levin wrote:
From: Chuhong Yuan <redacted> [ Upstream commit fc7b5028f2627133c7c18734715a08829eab4d1f ] an30259a_probe misses a check for devm_regmap_init_i2c and may cause problems. Add a check and print errors like other leds drivers.
Please drop. Pavel
quoted hunk ↗ jump to hunk
Signed-off-by: Chuhong Yuan <redacted> Signed-off-by: Pavel Machek <redacted> Signed-off-by: Sasha Levin <sashal@kernel.org> --- drivers/leds/leds-an30259a.c | 7 +++++++ 1 file changed, 7 insertions(+)diff --git a/drivers/leds/leds-an30259a.c b/drivers/leds/leds-an30259a.c index 250dc9d6f6350..82350a28a5644 100644 --- a/drivers/leds/leds-an30259a.c +++ b/drivers/leds/leds-an30259a.c@@ -305,6 +305,13 @@ static int an30259a_probe(struct i2c_client *client) chip->regmap = devm_regmap_init_i2c(client, &an30259a_regmap_config); + if (IS_ERR(chip->regmap)) { + err = PTR_ERR(chip->regmap); + dev_err(&client->dev, "Failed to allocate register map: %d\n", + err); + goto exit; + } + for (i = 0; i < chip->num_leds; i++) { struct led_init_data init_data = {};-- 2.20.1
-- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Attachments
- signature.asc [application/pgp-signature] 195 bytes