Thread (166 messages) 166 messages, 10 authors, 2018-11-06
STALE2811d REVIEWED: 2 (0M)

[PATCH 4.14 114/143] drm/i915/gvt: fix memory leak of a cmd_entry struct on error exit path

From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date: 2018-11-02 18:54:33
Also in: lkml

4.14-stable review patch.  If anyone has any objections, please let me know.

------------------

commit ffdf16edfbbe77f5f5c3c87fe8d7387ecd16241b upstream

The error exit path when a duplicate is found does not kfree and cmd_entry
struct and hence there is a small memory leak.  Fix this by kfree'ing it.

Detected by CoverityScan, CID#1370198 ("Resource Leak")

Fixes: be1da7070aea ("drm/i915/gvt: vGPU command scanner")
Signed-off-by: Colin Ian King <redacted>
Reviewed-by: Chris Wilson <redacted>
Signed-off-by: Zhenyu Wang <redacted>
Signed-off-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Acked-by: Zhenyu Wang <redacted>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
 drivers/gpu/drm/i915/gvt/cmd_parser.c |    1 +
 1 file changed, 1 insertion(+)
--- a/drivers/gpu/drm/i915/gvt/cmd_parser.c
+++ b/drivers/gpu/drm/i915/gvt/cmd_parser.c
@@ -2802,6 +2802,7 @@ static int init_cmd_table(struct intel_g
 		if (info) {
 			gvt_err("%s %s duplicated\n", e->info->name,
 					info->name);
+			kfree(e);
 			return -EEXIST;
 		}
 
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help