Re: [PATCH] net: macb: Fix regression breaking non-MDIO fixed-link PHYs

On 08/16/2018 04:24 PM, Andrew Lunn wrote:

1) A regression. We should find a fix for that. Maybe we should
   special case a child node called 'fixed-link' in
   of_mdiobus_register(). I would suggest adding a single warning if
   such node is found.

I just sent out a v2, which warns if fixed-link is encountered
in of_mdiobus_register(). The actual fixed-link handling remains in the
macb driver, because I think it's would be out of scope for a regression
fix to change where fixed-links are handled for all using drivers...

2) Missing functionality. Add support for an mdio container node. 

        node = of_get_child_by_name(np, "mdio");
        if (node)
		err = of_mdiobus_register(bp->mii_bus, node);
        else 
		err = of_mdiobus_register(bp->mii_bus, np);

Done.
 

3) Modify the existing dts files to make use of this container.
   Because of backwards compatibility, we cannot force the use of it,
   but we can encourage it.

Done as well.

Cheers
Ahmad