Thread (151 messages) 151 messages, 4 authors, 2018-02-22

[PATCH 4.14 117/167] console/dummy: leave .con_font_get set to NULL

flat view
STALE3155d

From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date: 2018-02-21 12:48:48
Also in: lkml

4.14-stable review patch.  If anyone has any objections, please let me know.

------------------

From: Nicolas Pitre <redacted>

commit 724ba8b30b044aa0d94b1cd374fc15806cdd6f18 upstream.

When this method is set, the caller expects struct console_font fields
to be properly initialized when it returns. Leave it unset otherwise
nonsensical (leaked kernel stack) values are returned to user space.

Signed-off-by: Nicolas Pitre <redacted>
Cc: stable@vger.kernel.org
Signed-off-by: Bartlomiej Zolnierkiewicz <redacted>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

---
 drivers/video/console/dummycon.c |    1 -
 1 file changed, 1 deletion(-)
--- a/drivers/video/console/dummycon.c
+++ b/drivers/video/console/dummycon.c
@@ -67,7 +67,6 @@ const struct consw dummy_con = {
     .con_switch =	DUMMY,
     .con_blank =	DUMMY,
     .con_font_set =	DUMMY,
-    .con_font_get =	DUMMY,
     .con_font_default =	DUMMY,
     .con_font_copy =	DUMMY,
 };
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help