[PATCH 4.13 16/85] usb: musb: sunxi: Explicitly release USB PHY on exit
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date: 2017-10-24 13:08:36
Also in:
lkml
4.13-stable review patch. If anyone has any objections, please let me know. ------------------ From: Jonathan Liu <redacted> commit 6ed05c68cbcae42cd52b8e53b66952bfa9c002ce upstream. This fixes a kernel oops when unloading the driver due to usb_put_phy being called after usb_phy_generic_unregister when the device is detached. Calling usb_phy_generic_unregister causes x->dev->driver to be NULL in usb_put_phy and results in a NULL pointer dereference. Signed-off-by: Jonathan Liu <redacted> Signed-off-by: Bin Liu <b-liu@ti.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> --- drivers/usb/musb/sunxi.c | 2 ++ 1 file changed, 2 insertions(+)
--- a/drivers/usb/musb/sunxi.c
+++ b/drivers/usb/musb/sunxi.c@@ -297,6 +297,8 @@ static int sunxi_musb_exit(struct musb * if (test_bit(SUNXI_MUSB_FL_HAS_SRAM, &glue->flags)) sunxi_sram_release(musb->controller->parent); + devm_usb_put_phy(glue->dev, glue->xceiv); + return 0; }