Thread (64 messages) 64 messages, 8 authors, 2017-10-31

Re: [PATCH 4.4 15/50] tty: goldfish: Fix a parameter of a call to free_irq

From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date: 2017-10-19 09:37:59
Also in: lkml

On Mon, Oct 16, 2017 at 08:46:06PM +0100, Ben Hutchings wrote:
On Fri, 2017-10-06 at 10:53 +0200, Greg Kroah-Hartman wrote:
quoted
4.4-stable review patch.��If anyone has any objections, please let me
know.

------------------

From: Christophe JAILLET <redacted>


[ Upstream commit 1a5c2d1de7d35f5eb9793266237903348989502b ]

'request_irq()' and 'free_irq()' should be called with the same
dev_id.
[...]

This fixes a bug introduced in 4.6 by commit 465893e18878 "tty:
goldfish: support platform_device with id -1".  For earlier kernel
versions, it *introduces* a bug.

Please revert from the 3.18 and 4.4 branches.
Ugh, the goldfish drivers are a pain lately...

I'll go revert this, luckily no one actually runs them in the tree :)

thanks,

greg k-h
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help