Re: [PATCH] KEYS: prevent KEYCTL_READ on negative key
- From
- David Howells <dhowells@redhat.com>
- Date
- 2017-09-19 16:09:07
- Also in
- keyrings, linux-security-module, lkml
- Reply to
- Eric Biggers, 2017-09-18
Eric Biggers [off-list ref] wrote:
quoted hunk ↗ jump to hunk
+ if (test_bit(KEY_FLAG_NEGATIVE, &key->flags)) { + ret = -ENOKEY; + goto error2; + }
It might be better to do this check in key_validate(). Also, it should
perhaps take the error from key->reject_error.
David