Thread (62 messages) 62 messages, 5 authors, 2017-10-11
STALE3199d REVIEWED: 1 (0M)

[PATCH 4.4 40/53] ANDROID: binder: fix proc->tsk check.

From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date: 2017-08-28 08:15:17
Also in: lkml

4.4-stable review patch.  If anyone has any objections, please let me know.

------------------

From: Martijn Coenen <redacted>

commit b2a6d1b999a4c13e5997bb864694e77172d45250 upstream.

Commit c4ea41ba195d ("binder: use group leader instead of open thread")'
was incomplete and didn't update a check in binder_mmap(), causing all
mmap() calls into the binder driver to fail.

Signed-off-by: Martijn Coenen <redacted>
Tested-by: John Stultz <redacted>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

---
 drivers/android/binder.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/android/binder.c
+++ b/drivers/android/binder.c
@@ -2869,7 +2869,7 @@ static int binder_mmap(struct file *filp
 	const char *failure_string;
 	struct binder_buffer *buffer;
 
-	if (proc->tsk != current)
+	if (proc->tsk != current->group_leader)
 		return -EINVAL;
 
 	if ((vma->vm_end - vma->vm_start) > SZ_4M)
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help